fix: 老师看作品不用先交；补学生看/评同学作品的权限漏洞；随机评分改成弹框

- 老师打开"作品"直接看，显示作者和得分；"同学作品"改名"作品"
- 随机评分只抽学生自己交过的题，不再泄露没做过的题的答案
- GET /submission/:id 学生打分前不返回同学的作者和得分（作品展除外）
- 打分要先能看这份提交
- AI 生成时随机评分弹框遮住页面，写完时正在看的那份留着，换成"看结果"

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

server/src/routes/review.ts

@@ -135,16 +135,19 @@ router.get("/class", (c) => {
 })
 
 // 学生看同学在这道题上的作品：自己交过才开放；自己打分之前不显示作者和得分。
-// scope=class 只看本班（默认，一个班几十份），scope=all 看全校所有班
+// 老师不受这两条限制。scope=class 只看本班（默认，一个班几十份），scope=all 看全校所有班
 router.get("/peers/:task_id", (c) => {
   const user = requireUser(c)
   const taskId = intParam(c, "task_id")
   const { scope } = query(c, z.object({ scope: z.enum(["class", "all"]).default("class") }))
   orNotFound(get(`SELECT 1 FROM task_task WHERE id = $id`, { id: taskId }), "任务不存在")
-  const submitted = get(
-    `SELECT 1 FROM submission_submission WHERE user_id = $me AND task_id = $task_id LIMIT 1`,
-    { me: user.id, task_id: taskId },
-  )
+  const staff = isStaff(user)
+  const submitted =
+    staff ||
+    get(`SELECT 1 FROM submission_submission WHERE user_id = $me AND task_id = $task_id LIMIT 1`, {
+      me: user.id,
+      task_id: taskId,
+    })
   if (!submitted) return c.json({ locked: true, items: [] })
   const byClass = scope === "class" && !!user.classname
   const members = `SELECT id FROM account_user
@@ -162,7 +165,7 @@ router.get("/peers/:task_id", (c) => {
   const items = [...rows.values()]
     .sort((a, b) => (a.created < b.created ? 1 : -1))
     .map((r) => {
-      const rated = (r.my_score || 0) > 0
+      const rated = staff || (r.my_score || 0) > 0
       const p = people.get(r.user_id)
       return {
         id: uuidOut(r.id),

server/src/routes/submission.ts

@@ -37,10 +37,12 @@ const router = new Hono<Env>()
 router.route("/showcase", showcase)
 router.route("/review", review)
 
+const inShowcase = (id: string) => !!get(`SELECT 1 FROM submission_submissionaward WHERE submission_id = $id`, { id })
+
 // 学生能看的提交：自己的、进了作品展的、自己也交过的那道题上同学（任何班）的。老师都能看
 function canView(user: User, sub: { id: string; user_id: number; task_id: number }) {
   if (isStaff(user) || sub.user_id === user.id) return true
-  if (get(`SELECT 1 FROM submission_submissionaward WHERE submission_id = $id`, { id: sub.id })) return true
+  if (inShowcase(sub.id)) return true
   return !!get(
     `SELECT 1 FROM submission_submission s WHERE s.user_id = $me AND s.task_id = $task_id LIMIT 1`,
     { me: user.id, task_id: sub.task_id },
@@ -336,7 +338,9 @@ router.get("/random-for-rating", (c) => {
   }
   if (user.role === Role.NORMAL && todayRatingCount(user.id) >= 30) return c.json(null)
 
+  // 学生只抽自己也交过的题（和同学作品一样，没交过的题不能看别人的答案）
   const cond = `s.user_id != $me
+      ${user.role === Role.NORMAL ? "AND +s.task_id IN (SELECT task_id FROM submission_submission WHERE user_id = $me)" : ""}
       AND NOT EXISTS (SELECT 1 FROM submission_rating r WHERE r.submission_id = s.id AND r.user_id = $me)
       ${excludeId ? "AND s.id != $exclude" : ""}`
   const params = { me: user.id, ...(excludeId ? { exclude: excludeId } : {}) }
@@ -545,7 +549,12 @@ router.get("/:id", (c) => {
   const id = uuidParam(c, "id")
   requireView(user, id)
   const s = orNotFound(get(`${SUBMISSION_SELECT} ${SUBMISSION_FROM} WHERE s.id = $id`, { me: user.id, id }))
-  return c.json(submissionOut(s))
+  const out = submissionOut(s)
+  // 和同学作品一样：学生给同学打分之前不告诉作者和得分（作品展里的本来就署名）
+  if (!isStaff(user) && s.user_id !== user.id && !out.my_score && !inShowcase(id)) {
+    return c.json({ ...out, userid: null, username: null, score: null })
+  }
+  return c.json(out)
 })
 
 // 增加浏览次数（仅在全屏预览时调用）
@@ -562,6 +571,7 @@ router.put("/:id/score", async (c) => {
   const id = uuidParam(c, "id")
   const { score } = await body(c, z.object({ score: z.number().int().max(5) }))
   if (score <= 0) throw new HttpError(400, "分数不能为零")
+  requireView(user, id)
   const sub = orNotFound(
     get<{ user_id: number; username: string }>(
       `SELECT s.user_id, u.username FROM submission_submission s

server/tests/api.test.ts

@@ -171,6 +171,8 @@ describe("评分", () => {
     expect(row.score).toBeCloseTo(4.25)
     expect(row.zone).toBe("pending")
 
+    // 学生要自己也交过这道题才能打分
+    for (let i = 0; i < 3; i++) makeSubmission(get(`SELECT id FROM account_user WHERE username = 's${i}'`).id, task)
     for (let i = 0; i < 3; i++) {
       await (await client(`s${i}`))("PUT", `/api/submission/${uuid(sub)}/score`, { score: 5 })
     }
@@ -256,8 +258,9 @@ describe("提交与删除", () => {
 
   test("删除一轮对话：连带提问和关联提交；被评过分的不能删", async () => {
     makeUser("stu")
-    makeUser("other")
+    const other = makeUser("other")
     const task = makeTask("T")
+    const otherSub = makeSubmission(other, task)
     const stu = await client("stu")
     const first = await stu("POST", "/api/submission/", { task_id: task, html: "<p>1", prompt: "第一版" })
     const second = await stu("POST", "/api/submission/", { task_id: task, html: "<p>2", prompt: "第二版" })
@@ -270,14 +273,16 @@ describe("提交与删除", () => {
     const res = await stu("DELETE", `/api/prompt/messages/${asstOf(first.json.id)}/pair`)
     expect(res.json).toEqual({ deleted: true, submission_deleted: true })
     expect(all(`SELECT content FROM prompt_message WHERE role = 'user'`)).toEqual([{ content: "第二版" }])
-    expect(all(`SELECT COUNT(*) AS n FROM submission_submission`)).toEqual([{ n: 1 }])
+    expect(all(`SELECT COUNT(*) AS n FROM submission_submission WHERE id != $id`, { id: otherSub })).toEqual([{ n: 1 }])
   })
 
   test("被评分的提交只有超管能删", async () => {
     const author = makeUser("author")
-    makeUser("other")
+    const other = makeUser("other")
     makeUser("boss", "super")
-    const sub = makeSubmission(author, makeTask("T"))
+    const task = makeTask("T")
+    const sub = makeSubmission(author, task)
+    makeSubmission(other, task)
     await (await client("other"))("PUT", `/api/submission/${uuid(sub)}/score`, { score: 4 })
     expect((await (await client("author"))("DELETE", `/api/submission/${uuid(sub)}`)).status).toBe(400)
     expect((await (await client("boss"))("DELETE", `/api/submission/${uuid(sub)}`)).status).toBe(200)
@@ -511,7 +516,10 @@ describe("同学作品与批改", () => {
 
     expect((await stu("GET", `/api/submission/${uuid(otherSub)}`)).status).toBe(403)
     makeSubmission(me, task)
-    expect((await stu("GET", `/api/submission/${uuid(mateSub)}`)).status).toBe(200)
+    const peer = await stu("GET", `/api/submission/${uuid(mateSub)}`)
+    expect(peer.status).toBe(200)
+    // 打分前不显示作者和得分
+    expect(peer.json).toMatchObject({ userid: null, username: null, score: null })
     // 交过以后外班的也能看
     expect((await stu("GET", `/api/submission/${uuid(otherSub)}`)).status).toBe(200)
     // 没交过的题仍然看不到
@@ -533,6 +541,11 @@ describe("同学作品与批改", () => {
     const mateSub = makeSubmission(mate, task)
     const stu = await client("me")
 
+    // 没交过的同学既不能打分，也抽不到这道题
+    const other = await client("other")
+    expect((await other("PUT", `/api/submission/${uuid(mateSub)}/score`, { score: 3 })).status).toBe(403)
+    expect((await other("GET", "/api/submission/random-for-rating")).json).toBeNull()
+
     let peers = await stu("GET", `/api/submission/review/peers/${task}`)
     expect(peers.json.items).toHaveLength(1)
     expect(peers.json.items[0]).toMatchObject({ id: uuid(mateSub), username: null, score: null, my_score: 0 })
@@ -541,17 +554,24 @@ describe("同学作品与批改", () => {
     expect(rated.json.username).toBe("mate")
     peers = await stu("GET", `/api/submission/review/peers/${task}`)
     expect(peers.json.items[0]).toMatchObject({ username: "mate", my_score: 4 })
-
-    const random = await (await client("other"))("GET", "/api/submission/random-for-rating")
-    expect(random.json.username).toBeUndefined()
+    expect((await stu("GET", `/api/submission/${uuid(mateSub)}`)).json).toMatchObject({ username: "mate" })
 
     // 默认只看本班；scope=all 能看到外班，标着班级，同样匿名
     const otherSub = makeSubmission(get(`SELECT id FROM account_user WHERE username = 'other'`).id, task)
+    const random = await other("GET", "/api/submission/random-for-rating")
+    expect(random.json.submission_id).toBeDefined()
+    expect(random.json.username).toBeUndefined()
     const all = await stu("GET", `/api/submission/review/peers/${task}?scope=all`)
     expect(all.json.items.map((w: any) => [w.classname, w.username])).toContainEqual(["c2", null])
     expect(all.json.items.map((w: any) => w.id)).toContain(uuid(otherSub))
     const mine = await stu("GET", `/api/submission/review/peers/${task}`)
     expect(mine.json.items.map((w: any) => w.classname)).toEqual(["c1"])
+
+    // 老师没交过也能看，直接显示作者
+    makeUser("t", "admin")
+    const teacher = await (await client("t"))("GET", `/api/submission/review/peers/${task}`)
+    expect(teacher.json.locked).toBe(false)
+    expect(teacher.json.items.map((w: any) => w.username).sort()).toEqual(["mate", "me", "other"])
   })
 
   test("老师按班级 × 任务看作品墙；课上展示用 flag", async () => {