From ceba1c68f2015c985247e87056829eb07cbd3c35 Mon Sep 17 00:00:00 2001
From: yuetsh <517252939@qq.com>
Date: Mon, 26 Oct 2026 18:36:54 +0800
Subject: [PATCH] =?UTF-8?q?fix:=20=E4=BF=AE=E5=A4=8D=E6=B3=A8=E5=86=8C?=
 =?UTF-8?q?=E5=92=8C=E4=B8=8A=E4=BC=A0=E7=B4=A0=E6=9D=90=E5=9C=A8=20await?=
 =?UTF-8?q?=20=E5=89=8D=E5=90=8E=E7=9A=84=E5=B9=B6=E5=8F=91=E7=AB=9E?=
 =?UTF-8?q?=E6=80=81=EF=BC=9B=E8=A1=A5=E5=85=85=20SQLite=20=E5=86=99?=
 =?UTF-8?q?=E6=B3=95=E8=AF=B4=E6=98=8E?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- 注册 / 新建用户 / 批量建用户：先算密码哈希，再同步地查重和插入，
  同名并发请求返回 400 而不是撞唯一约束变成 500
- 上传任务素材改用 INSERT ... ON CONFLICT DO UPDATE
- CLAUDE.md 补充同步阻塞、行内大文本列、索引、类型差异等注意事项
- 忽略根目录的 db.sqlite3（线上数据备份）

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---
 .gitignore                   |  1 +
 CLAUDE.md                    |  4 ++++
 server/src/routes/account.ts |  9 ++++++---
 server/src/routes/files.ts   | 15 ++++++---------
 4 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/.gitignore b/.gitignore
index 2a16763..efe24ad 100644
--- a/.gitignore
+++ b/.gitignore
@@ -5,6 +5,7 @@
 /media/
 /redis/
 /sqlite/
+/db.sqlite3*
 
 # 本地工具目录
 .agents/
diff --git a/CLAUDE.md b/CLAUDE.md
index e5df0f0..20a3c1d 100644
--- a/CLAUDE.md
+++ b/CLAUDE.md
@@ -67,6 +67,10 @@ docker compose run --rm webpreview-api bun scripts/create-superuser.ts <username
 
 - **Schema changes**: there is no migration framework. Edit the DDL in `src/db.ts` for new tables; for altering existing tables add an idempotent step guarded by `PRAGMA user_version`
 - **SQL style**: raw SQL with named params (`$id`), `strict: true` so params are passed without the `$` prefix (`{ id }`). Wrap multi-statement writes in `tx()`. Deleting tasks/submissions must go through `services/cascade.ts`
+- **Queries block the whole server**: `bun:sqlite` is synchronous in a single process, so a slow query stalls every HTTP request and WebSocket. Request-path queries must take milliseconds; batch work goes in `scripts/`. Never `await` inside `tx()` (it would commit early). Code with no `await` runs atomically, so read-check-write needs no locking; races only happen across an `await`
+- **Wide rows**: unlike Postgres (TOAST), SQLite keeps `html/css/js` and `prompt_message.content/code_*` inline, and Django's column order puts `user_id`, `task_id`, `flag`, `zone`, `raw_score` *after* them, so reading those columns from the table reads the whole code. List/scan queries must not select the big columns: page on indexes first (select `rowid`s with `ORDER BY ... LIMIT`), then fetch full rows for just that page (see `GET /submission/`, `random-for-rating`)
+- **Indexes**: SQLite uses one index per table for AND conditions (no BitmapAnd), so multi-column filters need a composite index (equality columns first, then range/sort). Hot scans on `submission_submission` must be covered by `submission_submission_slim`; compare `rowid` rather than `id` (`id` is a separate index). The planner only has stats via `PRAGMA optimize` (run on open and hourly), and may pick a poor single-column index — check new queries with `EXPLAIN QUERY PLAN` (no `SCAN` of big tables, ideally `COVERING INDEX`); a unary `+` (`+s.zone = $zone`) stops a column's index from being used. `CREATE INDEX IF NOT EXISTS` matches by name only, so a changed index needs a new name (drop the old one in a `user_version` step)
+- **Types**: booleans are `0/1`; timestamps are text compared as strings, so only write values from `now()` (never `CURRENT_TIMESTAMP` / `datetime('now')`); text sorts by code point; `ORDER BY ... ASC` puts NULLs first (Postgres: last), so add `NULLS LAST` where it matters; no `ILIKE` / `DISTINCT ON`
 - **API compatibility**: response shapes, status codes and trailing-slash tolerance (`strict: false`) mirror the old django-ninja API, so the client needed no changes besides user management. Paginated endpoints take `page` / `page_size` (default 10, max 100) and return `{ items, count }`
 - **Task `display` field**: integer used as URL slug for tutorials/challenges/creations (unique per task type), not the DB `id`
 - **Submission / conversation IDs**: UUIDs in the API, 32-char hex in the DB
diff --git a/server/src/routes/account.ts b/server/src/routes/account.ts
index 73f5a3f..80f5ae8 100644
--- a/server/src/routes/account.ts
+++ b/server/src/routes/account.ts
@@ -30,12 +30,15 @@ async function insertUser(u: {
   classname?: string
   email?: string
 }) {
+  // 先算哈希（异步），再同步地查重 + 插入：中间没有 await，并发注册同名不会撞唯一约束变成 500
+  const password = await makePassword(u.password)
+  if (userExists(u.username)) throw new HttpError(400, "用户已存在")
   const res = run(
     `INSERT INTO account_user
        (password, last_login, is_superuser, username, email, is_staff, is_active, date_joined, role, raw_password, classname)
      VALUES ($password, NULL, 0, $username, $email, 0, 1, $now, $role, $raw, $classname)`,
     {
-      password: await makePassword(u.password),
+      password,
       username: u.username,
       email: u.email ?? "",
       now: now(),
@@ -59,7 +62,6 @@ router.post("/register", async (c) => {
       password: z.string().min(6).max(20),
     }),
   )
-  if (userExists(payload.username)) throw new HttpError(400, "用户已存在")
   await insertUser(payload)
   return c.json({ message: "创建成功" })
 })
@@ -148,6 +150,8 @@ router.post("/batch", async (c) => {
   )
   const ts = now()
   tx(() => {
+    // 算哈希期间可能有人建了同名用户，插入前在同一个同步事务里再查一次
+    if (usernames.some(userExists)) throw new HttpError(400, "有些用户已经存在，创建失败")
     for (const u of users) {
       run(
         `INSERT INTO account_user
@@ -172,7 +176,6 @@ router.post("/create", async (c) => {
       classname: z.string().trim().max(50).default(""),
     }),
   )
-  if (userExists(payload.username)) throw new HttpError(400, "用户已存在")
   const id = await insertUser(payload)
   return c.json({ id, message: "创建成功" })
 })
diff --git a/server/src/routes/files.ts b/server/src/routes/files.ts
index 206599d..4a1a08e 100644
--- a/server/src/routes/files.ts
+++ b/server/src/routes/files.ts
@@ -96,15 +96,12 @@ for (const kind of ["challenge", "tutorial"] as const) {
       `tasks/${task.task_type}/${task.display}/${validFilename(name)}`,
       file,
     )
-    if (existing) {
-      run(`UPDATE task_taskasset SET file = $file WHERE id = $id`, { file: stored, id: existing.id })
-    } else {
-      run(`INSERT INTO task_taskasset (name, file, task_id) VALUES ($name, $file, $task_id)`, {
-        name,
-        file: stored,
-        task_id: task.id,
-      })
-    }
+    // 上面 await 期间可能有同名上传先写入了，用 upsert 而不是按 existing 选 INSERT / UPDATE
+    run(
+      `INSERT INTO task_taskasset (name, file, task_id) VALUES ($name, $file, $task_id)
+       ON CONFLICT (task_id, name) DO UPDATE SET file = excluded.file`,
+      { name, file: stored, task_id: task.id },
+    )
     return c.json(assetOut({ name, file: stored }))
   })