support share submission

submission/models.py

@@ -30,7 +30,7 @@ class Submission(models.Model):
     username = models.CharField(max_length=30)
     code = models.TextField()
     result = models.IntegerField(db_index=True, default=JudgeStatus.PENDING)
-    # 判题结果的详细信息
+    # 从JudgeServer返回的判题详情
     info = JSONField(default=dict)
     language = models.CharField(max_length=20)
     shared = models.BooleanField(default=False)
@@ -38,10 +38,12 @@ class Submission(models.Model):
     # {time_cost: "", memory_cost: "", err_info: "", score: 0}
     statistic_info = JSONField(default=dict)
 
-    def check_user_permission(self, user):
+    def check_user_permission(self, user, check_share=True):
         return self.user_id == user.id or \
-               self.shared is True or \
-               user.admin_type == AdminType.SUPER_ADMIN
+               (check_share and self.shared is True) or \
+               user.is_super_admin() or \
+               user.can_mgmt_all_problem() or \
+               self.problem.created_by_id == user.id
 
     class Meta:
         db_table = "submission"

submission/serializers.py

@@ -10,6 +10,11 @@ class CreateSubmissionSerializer(serializers.Serializer):
     contest_id = serializers.IntegerField(required=False)
 
 
+class ShareSubmissionSerializer(serializers.Serializer):
+    id = serializers.CharField()
+    shared = serializers.BooleanField()
+
+
 class SubmissionModelSerializer(serializers.ModelSerializer):
     info = serializers.JSONField()
     statistic_info = serializers.JSONField()
@@ -19,7 +24,7 @@ class SubmissionModelSerializer(serializers.ModelSerializer):
 
 
 # 不显示submission info的serializer, 用于ACM rule_type
-class SubmissionSafeSerializer(serializers.ModelSerializer):
+class SubmissionSafeModelSerializer(serializers.ModelSerializer):
     problem = serializers.SlugRelatedField(read_only=True, slug_field="_id")
     statistic_info = serializers.JSONField()
 
@@ -43,6 +48,6 @@ class SubmissionListSerializer(serializers.ModelSerializer):
 
     def get_show_link(self, obj):
         # 没传user或为匿名user
-        if self.user is None or self.user.id is None:
+        if self.user is None or not self.user.is_authenticated():
             return False
         return obj.check_user_permission(self.user)

submission/views/oj.py

@@ -7,8 +7,9 @@ from utils.api import APIView, validate_serializer
 from utils.throttling import TokenBucket, BucketController
 from utils.cache import cache
 from ..models import Submission
-from ..serializers import CreateSubmissionSerializer, SubmissionModelSerializer
-from ..serializers import SubmissionSafeSerializer, SubmissionListSerializer
+from ..serializers import (CreateSubmissionSerializer, SubmissionModelSerializer,
+                           ShareSubmissionSerializer)
+from ..serializers import SubmissionSafeModelSerializer, SubmissionListSerializer
 
 
 def _submit(response, user, problem_id, language, code, contest_id):
@@ -63,17 +64,37 @@ class SubmissionAPI(APIView):
     def get(self, request):
         submission_id = request.GET.get("id")
         if not submission_id:
-            return self.error("Parameter id doesn't exist.")
+            return self.error("Parameter id doesn't exist")
         try:
             submission = Submission.objects.select_related("problem").get(id=submission_id)
         except Submission.DoesNotExist:
-            return self.error("Submission doesn't exist.")
+            return self.error("Submission doesn't exist")
         if not submission.check_user_permission(request.user):
-            return self.error("No permission for this submission.")
+            return self.error("No permission for this submission")
 
         if submission.problem.rule_type == ProblemRuleType.ACM:
-            return self.success(SubmissionSafeSerializer(submission).data)
-        return self.success(SubmissionModelSerializer(submission).data)
+            submission_data = SubmissionSafeModelSerializer(submission).data
+        else:
+            submission_data = SubmissionModelSerializer(submission).data
+        # 是否有权限取消共享
+        submission_data["can_unshare"] = submission.check_user_permission(request.user, check_share=False)
+        return self.success(submission_data)
+
+    @validate_serializer(ShareSubmissionSerializer)
+    @login_required
+    def put(self, request):
+        try:
+            submission = Submission.objects.select_related("problem")\
+                .get(id=request.data["id"], contest__isnull=True)
+        except Submission.DoesNotExist:
+            return self.error("Submission doesn't exist")
+        if not submission.check_user_permission(request.user, check_share=False):
+            return self.error("No permission to share the submission")
+        if submission.contest and submission.contest.status == ContestStatus.CONTEST_UNDERWAY:
+            return self.error("Can not share submission during a contest going")
+        submission.shared = request.data["shared"]
+        submission.save(update_fields=["shared"])
+        return self.success()
 
 
 class SubmissionListAPI(APIView):
@@ -83,7 +104,7 @@ class SubmissionListAPI(APIView):
         if request.GET.get("contest_id"):
             return self.error("Parameter error")
 
-        submissions = Submission.objects.filter(contest_id__isnull=True)
+        submissions = Submission.objects.filter(contest_id__isnull=True).select_related("problem__created_by")
         problem_id = request.GET.get("problem_id")
         myself = request.GET.get("myself")
         result = request.GET.get("result")
@@ -112,7 +133,7 @@ class ContestSubmissionListAPI(APIView):
         if contest.rule_type == ContestRuleType.OI and not contest.is_contest_admin(request.user):
             return self.error("No permission for OI contest submissions")
 
-        submissions = Submission.objects.filter(contest_id=contest.id)
+        submissions = Submission.objects.filter(contest_id=contest.id).select_related("problem__created_by")
         problem_id = request.GET.get("problem_id")
         myself = request.GET.get("myself")
         result = request.GET.get("result")